[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

Shoaib Meenai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 5 09:44:42 PST 2017


smeenai added a subscriber: bcraig.
smeenai added a comment.

In https://reviews.llvm.org/D40774#945254, @halyavin wrote:

> In https://reviews.llvm.org/D40774#944751, @smeenai wrote:
>
> > In https://reviews.llvm.org/D40774#944749, @halyavin wrote:
> >
> > > In https://reviews.llvm.org/D40774#943993, @smeenai wrote:
> > >
> > > > Are you actually using libc++ with cl? :)
> > >
> > >
> > > People mostly use it to compile on Windows but I heard someone launches the result too. Since no one complains and it passed most of the testing, I guess the result doesn't explode. It is also part of catboost but I haven't tried how well it works there myself yet.
> >
> >
> > Hmm how is `#include_next` handled?
>
>
> About the same way as this proposed change: https://reviews.llvm.org/D32411 .
>
> PS Could you please commit this (https://reviews.llvm.org/D40774) change? I don't have commit rights.


Ah, that's good to know. CC @bcraig

Sorry, didn't know you didn't have commit access. I'll commit it for you.


https://reviews.llvm.org/D40774





More information about the cfe-commits mailing list