[PATCH] D39279: Stringizing raw string literals containing newline

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 5 04:33:00 PST 2017


jkorous-apple added a comment.

I see your concern. Would you just consider moving the annotation to header file then? It looks more like documentation of public interface than implementation details to me. I imagine any programmer interested in these methods needs to know these details so they would probably appreciate not having to search for it.

Anyway, I don't want to dwell on minor details and it's probably a matter of opinion as well. If you prefer to leave it as it is feel free to commit your patch.

Good job!

LGTM.


https://reviews.llvm.org/D39279





More information about the cfe-commits mailing list