[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

silviu.baranga@arm.com via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 5 02:07:46 PST 2017


sbaranga added inline comments.


================
Comment at: include/clang/Basic/Attr.td:1218-1228
 def NeonPolyVectorType : TypeAttr {
-  let Spellings = [GNU<"neon_polyvector_type">];
+  let Spellings = [Clang<"neon_polyvector_type">];
   let Args = [IntArgument<"NumElements">];
   let Documentation = [Undocumented];
 }
 
 def NeonVectorType : TypeAttr {
----------------
aaron.ballman wrote:
> aaron.ballman wrote:
> > rsmith wrote:
> > > I *think* these are a Clang invention rather than part of the ARM NEON intrinsics specification, but perhaps you could ask someone from ARM to confirm that.
> > @sbaranga or @jmolloy -- do you happen to know the answer to this, or know someone who does?
> Pinging this comment.
Yes, these should be internal to clang and used to implement the ACLE specification (which defines the NEON intrinsics). The ACLE doesn't define these.

Here is a link to the latest spec: https://developer.arm.com/products/software-development-tools/compilers/arm-compiler-5/docs/101028/latest/1-preface


https://reviews.llvm.org/D40625





More information about the cfe-commits mailing list