[PATCH] D33989: [OpenCL] Allow targets to select address space per type

[David Blaikie via cfe-commits]

Ping - I have a pretty clear workaround internally, but still would be
happy to remove any workarounds given the opportunity.

As for layering. For now the issue is that libAST depends on libBasic, and
libraries can't have circular dependencies. Modular builds (well,
especially modular codegen, but even not) can observe some of this/are
broken by this.

So the change as-is isn't acceptable. For now I think it'd be best to fix
the layering as it stands (add enums that can be passed down to Basic as
needed, for example (I haven't looked closely)) & if you believe Basic and
AST should be rolled together - maybe that's worthy of a discussion on
cfe-dev.

On Fri, Nov 17, 2017 at 9:56 AM Anastasia Stulova via Phabricator via
cfe-commits <cfe-commits at lists.llvm.org> wrote:

> Anastasia added a comment.
>
> Perhaps, I don't understand the concept of layered design in this
> particular case. But I just find it annoying that we need to re-implement
> the entire OpenCL AST Type structure in Basic. And even if we don't have
> dependencies on the files physically we still logically  bound to the AST
> representation in Basics and just entirely mirror it there.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D33989
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171205/55a637f2/attachment.html>