[PATCH] D40819: Implement Attribute Target MultiVersioning (Improved edition!)

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: include/clang/Basic/X86Target.def:148
 /// Cannonlake client microarchitecture based processors.
 PROC(Cannonlake, "cannonlake", PROC_64_BIT)
 
----------------
Cannonlake can prioritize off of VBMI or IFMA.


================
Comment at: include/clang/Basic/X86Target.def:236
 
+// List of CPU Supports features in order.  These need to remain in the order
+// required by attribute 'target' checking.
----------------
Should we document that not all of these are prioritized by gcc? So the next person who tries to match gcc for new features knows this.


https://reviews.llvm.org/D40819