[PATCH] D34082: [Frontend] 'Show hotness' can be used with a sampling profile

Fri Dec 1 10:40:36 PST 2017

davide added a comment.

In https://reviews.llvm.org/D34082#942420, @anemet wrote:

> @modocache, @davide, are you guys sure this feature is working?  The test does not actually check whether hotness is included in the remarks and when I run it manually they are missing.  In https://reviews.llvm.org/D40678, I am filtering out remarks with no hotness when any threshold is set all the remarks are filtered out in this new test.
>
> So either the test is incorrect or somehow with sample-based profiling we don't get hotness info.
>
> Any ideas?  I am inclined to just remove this test for now and file a bug to fix this in order to unblock https://reviews.llvm.org/D40678.

I don't know, I haven't reviewed this feature, but I can take a look later today.

https://reviews.llvm.org/D34082