[PATCH] D40733: [clangd] GlobalCompilationDatabase interface changes

[Sam McCall via Phabricator via cfe-commits]

sammccall created this revision.
Herald added subscribers: cfe-commits, klimek.

- GlobalCompilationDatabase now returns a single command (that's all we use)
- fallback flags are now part of the GlobalCompilationDatabase. There's a default implementation that they can optionally customize.
- this allows us to avoid invoking the fallback logic on two separate codepaths
- race on extra flags fixed by locking the mutex
- made GCD const-correct (DBGCD does have mutating methods)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D40733

Files:
  clangd/ClangdUnitStore.cpp
  clangd/GlobalCompilationDatabase.cpp
  clangd/GlobalCompilationDatabase.h
  unittests/clangd/ClangdTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40733.125151.patch
Type: text/x-patch
Size: 9300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171201/6370816f/attachment.bin>