[PATCH] D40705: [Parser] Diagnose storage classes in template parameter declarations

Faisal Vali via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 1 03:41:20 PST 2017


faisalv added inline comments.


================
Comment at: lib/Parse/ParseTemplate.cpp:692
+  //   declaration.
+  auto ReportStorageClass = [&](SourceLocation Loc) {
+    if (ParamDecl.getIdentifier())
----------------
I tend to prefer explicit captures (unless you have a good reason?) - favoring a clearer description of intention - and acknowledgement of required context - over programming convenience ...  


https://reviews.llvm.org/D40705





More information about the cfe-commits mailing list