[PATCH] D40486: [clangd] Implemented logging using Context

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 30 14:18:00 PST 2017


sammccall added a comment.

This is pretty bikesheddy, but I wonder what you think about passing Ctx as the first vs last parameter.
First has some advantages (maybe I just read too much Go though):

- it's a short expr, and F(short, long) tends to format better than F(long, short). Particularly with lambdas but also long strings.
- it doesn't interfere with default args

It would be nice if we could be completely uniform here.


https://reviews.llvm.org/D40486





More information about the cfe-commits mailing list