[PATCH] D40660: Enable auto-linking on Windows

[Reid Kleckner via Phabricator via cfe-commits]

rnk added inline comments.


================
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+#   if defined(_LIBCPP_DEBUG)
----------------
smeenai wrote:
> This feels more like a Windows (or perhaps COFF) thing than a Microsoft ABI thing.
I think if you're not using the MS ABI, you're probably using the GCC-style driver to compile and link, and that is what normally adds the C++ library to the link line.


================
Comment at: include/__config:1269
+#     pragma comment(lib, "c++d.lib")
+#   else
+#     pragma comment(lib, "c++.lib")
----------------
smeenai wrote:
> We never create a `c++d.lib`, as far as I can see. It's always either `c++.lib` for the import library or `libc++.lib` for the static library.
Yeah, I'd leave that out until we actually commit cmake or install scripts that make this library.


https://reviews.llvm.org/D40660