[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 30 01:41:04 PST 2017


ilya-biryukov added inline comments.


================
Comment at: lib/Sema/SemaCodeComplete.cpp:4609
 
+  if (SS.isInvalid()) {
+    CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
----------------
ioeric wrote:
> ilya-biryukov wrote:
> > ilya-biryukov wrote:
> > > Why do we alter this code path?
> > Maybe we should add a test or provide examples why the current code does not work for us?
> There is no existing unit test for CodeCompletion, and there is no much to test here either. I added a comment with example for this.
Makes sense, thanks for the explanation.


https://reviews.llvm.org/D40563





More information about the cfe-commits mailing list