[PATCH] D40640: Fix code completion crash with unresolved member expr and explicit base

Erik Verbruggen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 30 01:32:53 PST 2017


erikjv created this revision.

This is actually a failing assert. When doing object argument
initialization, it is valid to have e.g. 'this' as a base in a member
access expression (which is a prvalue). It's also possible to have a
scope specifier as part of the member expression, in which case a base
that is an actual lvalue gets wrapped in an ImplicitCastExpr, which in
turn is an rvalue.


https://reviews.llvm.org/D40640

Files:
  lib/Sema/SemaOverload.cpp
  test/CodeCompletion/member-access.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40640.124884.patch
Type: text/x-patch
Size: 4816 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171130/998a08bb/attachment.bin>


More information about the cfe-commits mailing list