[PATCH] D40618: [SourceLocations] Use stronger sort predicate to remove non-deterministic ordering
Mandeep Singh Grang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 29 12:55:51 PST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319357: [SourceLocations] Use stronger sort predicate to remove non-deterministic… (authored by mgrang).
Changed prior to commit:
https://reviews.llvm.org/D40618?vs=124798&id=124804#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40618
Files:
cfe/trunk/tools/libclang/CIndex.cpp
Index: cfe/trunk/tools/libclang/CIndex.cpp
===================================================================
--- cfe/trunk/tools/libclang/CIndex.cpp
+++ cfe/trunk/tools/libclang/CIndex.cpp
@@ -1025,8 +1025,9 @@
[&SM](Decl *A, Decl *B) {
SourceLocation L_A = A->getLocStart();
SourceLocation L_B = B->getLocStart();
- assert(L_A.isValid() && L_B.isValid());
- return SM.isBeforeInTranslationUnit(L_A, L_B);
+ return L_A != L_B ?
+ SM.isBeforeInTranslationUnit(L_A, L_B) :
+ SM.isBeforeInTranslationUnit(A->getLocEnd(), B->getLocEnd());
});
// Now visit the decls.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40618.124804.patch
Type: text/x-patch
Size: 625 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171129/e91c77da/attachment.bin>
More information about the cfe-commits
mailing list