[PATCH] D40601: [XRay][clang] Introduce -fxray-always-emit-customevents

[David Blaikie via Phabricator via cfe-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Not totally clear to me why this feature is desirable, but assume you've got use cases/reasons :)



================
Comment at: clang/lib/Driver/XRayArgs.cpp:32-33
 constexpr char XRayNeverInstrumentOption[] = "-fxray-never-instrument=";
+constexpr char XRayAlwaysEmitCustomEventsOption[] =
+    "-fxray-always-emit-customevents";
 } // namespace
----------------
Not clear to me there's a benefit to having these defined as constants versus using the literal directly - other parts of the driver use literals directly & there's are mostly used just once?


https://reviews.llvm.org/D40601