[PATCH] D39279: Stringizing raw string literals containing newline

Taewook Oh via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 29 10:29:38 PST 2017


twoh added a comment.

@jkorous-apple Thanks for the comments! Yeah, I was thinking of O(lenght_of_string) approach, but considering the complicatedness of the implementation (I guess the real implementation would be a bit more complex than your pseudo implementation to handle quote and '\n\r' '\r\n' cases) I decided to stay with O(length_of_string * number_of_endlines_in_string) but optimizing the number of move operations.

@vsapsai @jkorous-apple, I wonder if you can actually approve the patch or suggest other reviewers? Thanks!


https://reviews.llvm.org/D39279





More information about the cfe-commits mailing list