[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 29 09:49:30 PST 2017


sfertile added inline comments.


================
Comment at: include/clang/Driver/Options.td:1907
 def mvsx : Flag<["-"], "mvsx">, Group<m_ppc_Features_Group>;
+def msave_toc_indirect : Flag<["-"], "msave-toc-indirect">, Group<m_ppc_Features_Group>;
 def mno_vsx : Flag<["-"], "mno-vsx">, Group<m_ppc_Features_Group>;
----------------
hfinkel wrote:
> You also need mno_save_toc_indirect here too.
nit: The new option splits the mvsx and mno_vsx pair. I think we should keep the related options together. 


https://reviews.llvm.org/D39376





More information about the cfe-commits mailing list