[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

[Jan Korous via Phabricator via cfe-commits]

jkorous-apple added inline comments.


================
Comment at: tools/libclang/CIndexer.cpp:131
+  if (!File.empty())
+    llvm::sys::fs::remove(File);
+}
----------------
Just a thought - since we are not propagating errors from constructor we are not really sure we were able to create the file in the first place (e. g. return from ctor at line 103). Should we still try to delete it?


Repository:
  rC Clang

https://reviews.llvm.org/D40527