[PATCH] D40563: [SemaCodeComplete] Allow passing out scope specifiers in qualified-id completions via completion context.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:284
 
+  llvm::Optional<CXXScopeSpec> ScopeSpecifier;
+
----------------
Maybe add a brief comment for consistency with other decls?


================
Comment at: lib/Sema/SemaCodeComplete.cpp:4609
 
+  if (SS.isInvalid()) {
+    CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
----------------
Why do we alter this code path?


================
Comment at: lib/Sema/SemaCodeComplete.cpp:4611
+    CodeCompletionContext CC(CodeCompletionContext::CCC_Name);
+    CC.setCXXScopeSpecifier(SS);
+    HandleCodeCompleteResults(this, CodeCompleter, CC, nullptr, 0);
----------------
Do we really want to set invalid scope specifiers here?


https://reviews.llvm.org/D40563