[PATCH] D40310: Restructure how we break tokens.

[Krasimir Georgiev via Phabricator via cfe-commits]

krasimir added inline comments.


================
Comment at: lib/Format/ContinuationIndenter.cpp:1749
+      }
+      if (!Reflow) {
+        // If we didn't reflow into the next line, the only space to consider is
----------------
nit: Maybe change this to `if (Reflow)` and switch the if-else bodies.


================
Comment at: lib/Format/ContinuationIndenter.cpp:1777
+          assert(Penalty >= NewBreakPenalty);
+          Penalty -= NewBreakPenalty;
+        }
----------------
Shouldn't we be resetting `NewBreakBefore` to `false` here?


https://reviews.llvm.org/D40310