[PATCH] D40562: [Sema] Ignore decls in namespaces when global decls are not wanted.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 29 03:13:55 PST 2017


ilya-biryukov added a comment.

This is how I always perceived this option in the first place, so LGTM.
But maybe its intention is different, so we should wait for @arphaman's comments.

Could you also update comments of `CodeCompleteConsumer::includeGlobals` and `CodeCompleteOptions::IncludeGlobals` to indicate we ignore all namespace-level decls now (it currently only mentions top-level decls, which may be confusing).


https://reviews.llvm.org/D40562





More information about the cfe-commits mailing list