[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added inline comments.


================
Comment at: lib/Driver/ToolChain.cpp:458
+    if (Triple.getArch() == llvm::Triple::x86)
+      return llvm::ExceptionHandling::DwarfCFI;
+    else
----------------
I'd suggest braces around the outer if statement.

But is there any point to this default fallback here at all? Dwarf isn't right for x86 for MSVC, and we set the right defaults for all the MinGW cases in that driver in any case. So isn't it enough to just return None always here, or possibly WinEH for all windows cases?


Repository:
  rL LLVM

https://reviews.llvm.org/D39673