[PATCH] D40586: Implement p0457r2 - String Prefix and Suffix Checking

Marshall Clow via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 28 15:34:26 PST 2017


mclow.lists added a comment.

Sorry for the extra bits.



================
Comment at: include/string:1365
     static _LIBCPP_INLINE_VISIBILITY
     size_type __recommend(size_type __s) _NOEXCEPT
+        {
----------------
This is a leftover change. Disregard this bit.


================
Comment at: test/std/strings/basic.string/string.modifiers/string_append/push_back.pass.cpp:26
+
 template <class S>
 void
----------------
This one too.


================
Comment at: test/std/strings/basic.string/string.modifiers/string_append/push_back.pass.cpp:51
 #endif
+    {
+// https://bugs.llvm.org/show_bug.cgi?id=31454
----------------
This one three.


https://reviews.llvm.org/D40586





More information about the cfe-commits mailing list