[PATCH] D39114: [XRay][compiler-rt][Darwin] Minimal XRay build support in Darwin

[Dean Michael Berris via Phabricator via cfe-commits]

dberris added a comment.

In https://reviews.llvm.org/D39114#938134, @Hahnfeld wrote:

> I'm getting "multiple definition" errors on powerpc64le when linking the unit tests, for example `XRayBufferQueueTest`:
>
>   src/projects/compiler-rt/lib/xray/xray_utils.cc:34: multiple definition of `__xray::retryingWriteAll(int, char*, char*)'
>   src/projects/compiler-rt/lib/xray/xray_utils.cc:73: multiple definition of `__xray::readValueFromFile(char const*, long long*)'
>   src/projects/compiler-rt/lib/xray/xray_utils.cc:95: multiple definition of `__xray::getLogFD()'
>
>
> to name a few of the errors.


Fixed in https://reviews.llvm.org/rL319241.

> (related note: Why aren't the unit tests rebuilt if the `libclang_rt.xray-powerpc64le.a` changes?!? After reverting this commit locally for testing, the unit test built just fine. After reapplying the test wasn't rebuilt and I saw no problems...)

Yeah, that one I still haven't figured out yet. :/


https://reviews.llvm.org/D39114