[PATCH] D37806: [analyzer] PthreadLock: Fix return values of XNU lock functions.

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 28 09:11:07 PST 2017


NoQ added a comment.

Hey wb! Get well :)



================
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:282
+    }
+    // We might want to handle the case when the mutex lock function was inlined
+    // and returned an Unknown or Undefined value.
----------------
a.sidorin wrote:
> TODO?
That'd make a terrible project of choice for people grepping for TODOs and FIXMEs, so I guess rather not.


https://reviews.llvm.org/D37806





More information about the cfe-commits mailing list