[PATCH] D5767: Template Instantiation Observer + a few other templight-related changes

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun accepted this revision.
xazax.hun added a comment.

I found some nit, otherwise LG!

I think you should includ the context in the patches, that makes them reviewing much easier. See: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface



================
Comment at: include/clang/Sema/TemplateInstCallback.h:47
+  for (auto &C : Callbacks) {
+    if (C) {
+      C->initialize(TheSema);
----------------
We usually omit the braces for one line long single statements guarded by ifs. 


================
Comment at: lib/Frontend/FrontendActions.cpp:326
+private:
+  static std::string ToString(CodeSynthesisContext::SynthesisKind Kind) {
+    switch (Kind) {
----------------
The methods should start with a lowercase letter even if they are static.


https://reviews.llvm.org/D5767