[PATCH] D31739: Add markup for libc++ dylib availability

[Brian Cain via Phabricator via cfe-commits]

bcain added a comment.

I think some of the `XFAIL: availability` may be wrong here.  I'd submit a patch, but it's not clear to me what the appropriate fix is.



================
Comment at: libcxx/trunk/utils/libcxx/test/config.py:400
+        if self.use_system_cxx_lib or self.with_availability:
+            self.config.available_features.add('availability')
+            self.add_deployment_feature('availability')
----------------
This means that 'availability' is present if `use_system_cxx_lib` even on platforms other than OSX.  It's not clear to me whether or not this was intended.

If this was intended then it's probably wrong to "XFAIL: availability" in some of these tests.  This means that these tests went from PASS to XFAIL when "use_system_cxx_lib".  If perhaps these tests cannot be used without just-built libcxx, then maybe it makes more sense to mark them "UNSUPPORTED: availability"?


Repository:
  rL LLVM

https://reviews.llvm.org/D31739