[PATCH] D40325: add new check to find OSSpinlock usage
Ben Hamilton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 27 12:16:22 PST 2017
benhamilton added a comment.
Thanks, looks good. Just one question about the test.
================
Comment at: test/clang-tidy/objc-avoid-spinlock.m:4
+typedef int OSSpinLock;
+void OSSpinlockTry(OSSpinLock *__lock) {}
+
----------------
Not sure why you declared (and defined?) this one but not the others.
Either declare them all (no definition needed) or don't..
https://reviews.llvm.org/D40325
More information about the cfe-commits
mailing list