r319026 - [lit] Set shlibpath_var on Solaris

Fedor Sergeev via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 27 05:33:19 PST 2017


Author: fedor.sergeev
Date: Mon Nov 27 05:33:19 2017
New Revision: 319026

URL: http://llvm.org/viewvc/llvm-project?rev=319026&view=rev
Log:
[lit] Set shlibpath_var on Solaris

Summary:
During make check-all on Solaris, lit complains

llvm-lit: /vol/gcc/src/llvm/llvm/dist/tools/clang/test/Unit/lit.cfg.py:57: warning: unable to inject shared library path on 'SunOS'

The following patch avoids this: Solaris uses LD_LIBRARY_PATH like several other targets.

In theory, one could also handle LD_LIBRARY_PATH_{32,64} which take precedence over
LD_LIBRARY_PATH if set, but let's cross that bridge when we get there.

Patch by Rainer Orth.

Reviewers: rsmith, lichray
Reviewed By: lichray

Differential Revision: https://reviews.llvm.org/D39640

Modified:
    cfe/trunk/test/Unit/lit.cfg.py

Modified: cfe/trunk/test/Unit/lit.cfg.py
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Unit/lit.cfg.py?rev=319026&r1=319025&r2=319026&view=diff
==============================================================================
--- cfe/trunk/test/Unit/lit.cfg.py (original)
+++ cfe/trunk/test/Unit/lit.cfg.py Mon Nov 27 05:33:19 2017
@@ -36,7 +36,7 @@ for symbolizer in ['ASAN_SYMBOLIZER_PATH
         config.environment[symbolizer] = os.environ[symbolizer]
 
 def find_shlibpath_var():
-    if platform.system() in ['Linux', 'FreeBSD', 'NetBSD']:
+    if platform.system() in ['Linux', 'FreeBSD', 'NetBSD', 'SunOS']:
         yield 'LD_LIBRARY_PATH'
     elif platform.system() == 'Darwin':
         yield 'DYLD_LIBRARY_PATH'




More information about the cfe-commits mailing list