[PATCH] D40485: [clangd] Introduced a Context that stores implicit data
Benjamin Kramer via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 27 04:59:09 PST 2017
bkramer requested changes to this revision.
bkramer added inline comments.
This revision now requires changes to proceed.
================
Comment at: clangd/Context.h:79
+/// Otherwise returns an empty Context.
+Context &globalCtx();
+
----------------
This is a giant code smell. If we want the context route, please pass contexts everywhere. I really don't want this kind of technical debt in clangd now.
https://reviews.llvm.org/D40485
More information about the cfe-commits
mailing list