[PATCH] D38845: [ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType, DependentScopeDeclRefExpr

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 26 03:52:59 PST 2017


a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.

Hello Peter,

This looks good to me. But could you please check if test works if we add `-fms-compatibility` and `-fdelayed-template-parsing` to `Args`?



================
Comment at: unittests/AST/ASTImporterTest.cpp:611
+  EXPECT_TRUE(testImport("template <typename T> struct S;"
+                         "template <typename T> void declToImport() {"
+                         "  S<T>::foo;"
----------------
Uninstantiated templates make me worry about Windows buildbots. If they will start to fail, we should test these matchers with `-fms-compatibility` and `-fdelayed-template-parsing` options enabled.


https://reviews.llvm.org/D38845





More information about the cfe-commits mailing list