[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 24 10:42:54 PST 2017


aaron.ballman accepted this revision.
aaron.ballman added a comment.

In https://reviews.llvm.org/D39722#934781, @tk1012 wrote:

> Hello Aaron,
>
> I remove the semicolon.
>
> > Is this type actually correct for C++?
>
> Yes, it is.
>  clang generates the AST for `declToImport` struct like this.
>
>   |-CXXRecordDecl 0x8b19fe0 <col:22, col:29> col:29 implicit struct declToImport
>   `-CXXMethodDecl 0x8b1a0d0 <line:2:3, col:27> col:8 m 'void (void)'
>     `-CompoundStmt 0x8b1a1e8 <col:12, col:27>
>       `-TypeTraitExpr 0x8b1a1c8 <col:14, col:24> '_Bool'
>   


Hmm, that looks like a bug to me; but not one that should impact this review.

LGTM!


https://reviews.llvm.org/D39722





More information about the cfe-commits mailing list