[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

[Peter Szecsi via Phabricator via cfe-commits]

szepet added a comment.

Hello Aleksei,

Thank you for the review! (and sorry for the late update)



================
Comment at: lib/AST/ASTImporter.cpp:5510
+  UnresolvedSet<8> ToDecls;
+  for (Decl *D : E->decls()) {
+    if (NamedDecl *To = cast_or_null<NamedDecl>(Importer.Import(D)))
----------------
a.sidorin wrote:
> ImportContainerChecked
Since the `operator*` is const on `UnresolvedSetIterator` so returns `NameDecl*` not `NamedDecl*&` the ImportContainerChecked can not be use here as I understand (since the left side of the = operator is not an LVal in this case). So we can add elements via the `addDecl` function call.


https://reviews.llvm.org/D38694