[PATCH] D39722: [ASTImporter] Support TypeTraitExpr Importing

[Aleksei Sidorin via Phabricator via cfe-commits]

a.sidorin added a comment.

Hello Takafumi,

This is almost OK to me but there is an inline comment we need to resolve in order to avoid Windows buildbot failures.
In addition, as Gabor pointed, when we add a new matcher, we need to update matcher documentation as well. To update the docs, you should perform just three steps.

1. Rebase your patch onto latest master
2. Launch script docs/tools/dump_ast_matchers.py
3. Add changes made by this script to your commit.

After these changes are made, I will approve the patch. Thank you!



================
Comment at: unittests/AST/ASTImporterTest.cpp:554
+                         "  void m() { __is_pod(T); };"
+                         "};",
+                         Lang_CXX11, "", Lang_CXX11, Verifier,
----------------
Please add `void f() { declToImport<int>().m(); } after `declToImport` definition. The reason is that in MSVC mode, uninstantiated templates are ignored so the test will fail. We need this to avoid this.


https://reviews.llvm.org/D39722