[PATCH] D40301: [clangd] Ensure preamble outlives the AST
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 23 00:38:27 PST 2017
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clangd/ClangdUnit.h:51
+struct PreambleData;
+
----------------
can you move the definition here to avoid the extra decl?
(I tend to find this more readable and the struct is small, but if you prefer "top-down" that's fine too)
https://reviews.llvm.org/D40301
More information about the cfe-commits
mailing list