[PATCH] D40023: [RISCV] Implement ABI lowering

Ana Pazos via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 22 09:38:59 PST 2017


apazos added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:8872
+  else
+    NeededArgGPRs = 1;
+
----------------
Suggestion to make 1 default value when you declare the var


================
Comment at: lib/CodeGen/TargetInfo.cpp:8938
+
+  // The size of the actual thing passed, which might end up just
+  // being a pointer for indirect types.
----------------
The size -> The type


https://reviews.llvm.org/D40023





More information about the cfe-commits mailing list