[PATCH] D34158: For Linux/gnu compatibility, preinclude <stdc-predef.h> if the file is available

[Melanie Blower via Phabricator via cfe-commits]

mibintc reopened this revision.
mibintc added a comment.

Hi.

I also posted this question on IRC

@erichkeane pushed a fix for https://reviews.llvm.org/D34158 which on Linux does a preinclude of stdc-predef.h; on Monday. Later on Monday he pulled it out because it caused 3 test failures and word-of-mouth that it also caused chromium build to fail. I haven't been watching this IRC so I didn't catch the details about the chromium build fail.

if you know, can you send me details about how/why chromium build fails?

also, the 3 tests (2 lit tests, 1 google test) which failed on buildbot do not fail on the linux servers in-house at Intel. Any clue about why that would be? I have a patched compiler, and verify that the new functionality is present. I build check-clang and there are no fails.

I looked with llvm-lit at each of the 2 failing tests and they don't fail, I checked the google test libclang "skip ranges" and it doesn't fail

also maybe i should redirect this question elsewhere.  don't hesitate to let me know

also i have used the self-build for https://reviews.llvm.org/D34158 and likewise those 3 tests do not fail.

i used "llvm-lit -a" on one of the failing tests test/Modules/crash-vfs-path-symlink-component.m to see why the test was failing. i was not able to run the commands directly from the linux shell
 the lit command that didn't work is not env FORCE_CLANG_DIAGNOSTICS_CRASH= ...
 it's the "not" which is not understood - does that ring a bell?  it works OK within llvm-lit
sptel9-ws/llorg1/builds/llorgefi2linux_debug/llvm/bin/count 1 ; the buildbot is showing 2 not 1


Repository:
  rL LLVM

https://reviews.llvm.org/D34158