[PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

Evgeny Astigeevich via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 22 05:08:03 PST 2017


Yes, r318830 has made our libcxx buildbots green.  The public ones should become green as well.

Thanks,
Evgeny

-----Original Message-----
From: Billy O'Neal <billy.oneal at gmail.com>
Date: Wednesday, 22 November 2017 at 12:30
To: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>
Cc: "reviews+D40065+public+cdf4c853d41b47de at reviews.llvm.org" <reviews+D40065+public+cdf4c853d41b47de at reviews.llvm.org>, Billy Robert O'Neal III via Phabricator <reviews at reviews.llvm.org>, "eric at efcs.ca" <eric at efcs.ca>, "mclow.lists at gmail.com" <mclow.lists at gmail.com>, "cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>, nd <nd at arm.com>
Subject: Re: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.

OK, I think r318830 fixes the other one here. Thanks!

Billy3

On Wed, Nov 22, 2017 at 4:25 AM, Billy O'Neal <billy.oneal at gmail.com> wrote:
> Sorry, I saw one bot fail and I thought I fixed it with
> 37332d772480307af423fbea817c29a0832be86e but apparently there were
> others I missed.
>
> On Wed, Nov 22, 2017 at 4:04 AM, Evgeny Astigeevich
> <Evgeny.Astigeevich at arm.com> wrote:
>> Hi Billy,
>>
>> These changes caused buildbot failures: tuple.by.type.fail.cpp Line 19: unknown type name 'TEST_IGNORE_NODISCARD'
>>
>> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx14/builds/1109
>> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx17/builds/1
>> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-arm-linux/builds/924
>> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-libunwind-aarch64-linux/builds/972
>>
>> Thanks,
>> Evgeny Astigeevich
>>
>>
>> -----Original Message-----
>> From: cfe-commits <cfe-commits-bounces at lists.llvm.org> on behalf of Billy Robert O'Neal III via Phabricator via cfe-commits <cfe-commits at lists.llvm.org>
>> Reply-To: "reviews+D40065+public+cdf4c853d41b47de at reviews.llvm.org" <reviews+D40065+public+cdf4c853d41b47de at reviews.llvm.org>, Billy Robert O'Neal III via Phabricator <reviews at reviews.llvm.org>
>> Date: Tuesday, 21 November 2017 at 21:38
>> To: "billy.oneal at gmail.com" <billy.oneal at gmail.com>, "eric at efcs.ca" <eric at efcs.ca>, "mclow.lists at gmail.com" <mclow.lists at gmail.com>
>> Cc: "cfe-commits at lists.llvm.org" <cfe-commits at lists.llvm.org>
>> Subject: [PATCH] D40065: [libcxx] [test] Change (void)s to TEST_IGNORE_NODISCARD as requested by Eric.
>>
>> BillyONeal closed this revision.
>> BillyONeal added a comment.
>>
>> Committed r318804
>>
>>
>> https://reviews.llvm.org/D40065
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>>




More information about the cfe-commits mailing list