[PATCH] D39836: [clangd] Drop impossible completions (unavailable or inaccessible)

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 22 02:12:08 PST 2017


ilya-biryukov added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:169
+  clangd::CodeCompleteOptions CCOpts;
+  CCOpts.EnableSnippets = EnableSnippets;
+  CCOpts.IncludeIneligibleResults = IncludeIneligibleResults;
----------------
We should also set `IncludeCodePatterns = EnableSnippets` here.  May be worth adding a test that they are in the completion results.


https://reviews.llvm.org/D39836





More information about the cfe-commits mailing list