[PATCH] D40224: [X86] Control-Flow Enforcement Technology - Shadow Stack and Indirect Branch Tracking support (Clang side)

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: include/clang/Basic/BuiltinsX86_64.def:63
 TARGET_BUILTIN(__builtin_ia32_xsaves64, "vv*ULLi", "", "xsaves")
+TARGET_BUILTIN(__builtin_ia32_incsspq, "vULLi","u","shstk")
+TARGET_BUILTIN(__builtin_ia32_rdsspq, "ULLiULLi","Un","shstk")
----------------
Space after commas here too.


================
Comment at: test/Preprocessor/x86_target_features.c:336
 
+// RUN: %clang -target i386-unknown-unknown -mcet -x c -E -dM -o - %s | FileCheck -match-full-lines --check-prefix=CET %s
+
----------------
Should this -mcet case be removed?


Repository:
  rL LLVM

https://reviews.llvm.org/D40224