[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 20 23:02:53 PST 2017


aaron.ballman added a comment.

In https://reviews.llvm.org/D40242#931173, @ogoffart wrote:

> > You should add a test case that demonstrates code which would otherwise trigger an analysis-based warning but doesn't due to disabling all warnings.
>
> No warnings are triggered. Because the diagnostic engine ignores them.
>  This just optimize the code so no analysis are preformed when no warning can be triggered.


Correct -- I'm asking for a test that ensures we don't regress the intended behavior of this patch by accident at some point (behavioral changes should always have at least one accompanying test).


https://reviews.llvm.org/D40242





More information about the cfe-commits mailing list