[PATCH] D40275: [CUDA] Report "unsupported VLA" errors only on device side.
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 20 16:34:16 PST 2017
tra created this revision.
Herald added a subscriber: sanjoy.
This fixes erroneously reported CUDA compilation errors in host-side code during device-side compilation.
I've also restricted OpenMP-specific checks to trigger only if we're compiling with OpenMP enabled.
https://reviews.llvm.org/D40275
Files:
clang/lib/Sema/SemaType.cpp
Index: clang/lib/Sema/SemaType.cpp
===================================================================
--- clang/lib/Sema/SemaType.cpp
+++ clang/lib/Sema/SemaType.cpp
@@ -2180,14 +2180,17 @@
Diag(Loc, diag::err_opencl_vla);
return QualType();
}
- // CUDA device code doesn't support VLAs.
- if (getLangOpts().CUDA && T->isVariableArrayType())
- CUDADiagIfDeviceCode(Loc, diag::err_cuda_vla) << CurrentCUDATarget();
- // Some targets don't support VLAs.
- if (T->isVariableArrayType() && !Context.getTargetInfo().isVLASupported() &&
- shouldDiagnoseTargetSupportFromOpenMP()) {
- Diag(Loc, diag::err_vla_unsupported);
- return QualType();
+ if (T->isVariableArrayType()) {
+ if (getLangOpts().CUDA) {
+ // CUDA device code doesn't support VLAs.
+ CUDADiagIfDeviceCode(Loc, diag::err_cuda_vla) << CurrentCUDATarget();
+ } else if (getLangOpts().OpenMP &&
+ !Context.getTargetInfo().isVLASupported() &&
+ shouldDiagnoseTargetSupportFromOpenMP()) {
+ // Some targets don't support VLAs.
+ Diag(Loc, diag::err_vla_unsupported);
+ return QualType();
+ }
}
// If this is not C99, extwarn about VLA's and C99 array size modifiers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40275.123689.patch
Type: text/x-patch
Size: 1225 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171121/c869adb0/attachment.bin>
More information about the cfe-commits
mailing list