[PATCH] D40250: [OpenMP] Consistently use cubin extension for nvlink

[Jonas Hahnfeld via Phabricator via cfe-commits]

Hahnfeld marked 2 inline comments as done.
Hahnfeld added inline comments.


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:431
 
-    SmallString<256> Name(II.getFilename());
-    llvm::sys::path::replace_extension(Name, "cubin");
-
-    const char *CubinF =
-        C.addTempFile(C.getArgs().MakeArgString(Name));
+    const char *CubinF = C.addTempFile(
+        C.getArgs().MakeArgString(getToolChain().getInputFilename(II)));
----------------
gtbercea wrote:
> Is this always a cubin?
Probably because the linker always takes object files...


================
Comment at: lib/Driver/ToolChains/Cuda.cpp:461
+std::string CudaToolChain::getInputFilename(const InputInfo &Input) const {
+  if (OK != Action::OFK_OpenMP || Input.getType() != types::TY_Object)
+    return ToolChain::getInputFilename(Input);
----------------
gtbercea wrote:
> When does this situation occur?
Well, if that condition fires:
1. For CUDA
2. For other types. For example, the bundler might need to bundle / unbundle assembly files.


https://reviews.llvm.org/D40250