[PATCH] D40242: Do not perform the analysis based warning if all warnings are ignored

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In https://reviews.llvm.org/D40242#930125, @ogoffart wrote:

> I do not know how to add a test: there is no real visible change for clang. It just should be faster when passing "-w".


Oh right, i was thinking of something else there.



================
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:2084
+  // Do not do any analysis if we are going to just ignore them.
+  if (Diags.getIgnoreAllWarnings() ||
+      (Diags.getSuppressSystemWarnings() &&
----------------
I guess you can try commenting-out that entire check and seeing whether any test fails.


https://reviews.llvm.org/D40242