[PATCH] D39627: Fix vtable not receiving hidden visibility when using push(visibility)

Jake Ehrlich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 17 12:47:23 PST 2017


jakehehrlich updated this revision to Diff 123399.
jakehehrlich added a comment.

1. Added a ForDefinition parameter to setGlobalVisibility and merged visibility setting behaviors for setGlobalVisibility and setLinkageAndVisibilityForGV
2. Renamed setLinkageAndVisibilityForGV to setLinkageForGV
3. refactored calls to these two functions to match their new form.


Repository:
  rL LLVM

https://reviews.llvm.org/D39627

Files:
  lib/CodeGen/CGDecl.cpp
  lib/CodeGen/CGVTT.cpp
  lib/CodeGen/CGVTables.cpp
  lib/CodeGen/CodeGenModule.cpp
  lib/CodeGen/CodeGenModule.h
  lib/CodeGen/ItaniumCXXABI.cpp
  test/CodeGen/push-hidden-visibility-subclass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39627.123399.patch
Type: text/x-patch
Size: 7534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171117/186c01b9/attachment.bin>


More information about the cfe-commits mailing list