[PATCH] D35894: [clangd] Code hover for Clangd

[William Enright via Phabricator via cfe-commits]

Nebiroth marked 6 inline comments as done.
Nebiroth added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:981
+    }
+
     if (isSearchedLocation(FID, Offset)) {
----------------
malaperle wrote:
> I think we need to do a check that the computed SourceRange is valid (isValid) in case we get it wrong. Otherwise, it might not go well later when we use the SourceLocation to convert to lines, etc.
Do we just output a default Range values when SR isn't valid?


https://reviews.llvm.org/D35894