[PATCH] D33989: [OpenCL] Allow targets to select address space per type

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 17 09:56:35 PST 2017


Anastasia added a comment.

Perhaps, I don't understand the concept of layered design in this particular case. But I just find it annoying that we need to re-implement the entire OpenCL AST Type structure in Basic. And even if we don't have dependencies on the files physically we still logically  bound to the AST representation in Basics and just entirely mirror it there.


Repository:
  rL LLVM

https://reviews.llvm.org/D33989





More information about the cfe-commits mailing list