[PATCH] D40182: [clangd] Add parsing and value inspection to JSONExpr.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 17 09:37:46 PST 2017


sammccall created this revision.
Herald added a subscriber: ilya-biryukov.

This will replace the places where we're using YAMLParser to parse JSON now:

- the new marshalling code (T::parse()) should handle fewer cases and require fewer explicit casts
- we'll early-reject invalid JSON that YAMLParser accepts
- we'll be able to fix protocol-parsing bugs caused by the fact that YAML can only parse forward

I plan to do the conversion as soon as this lands, but I don't want it in one
patch as the protocol.cpp changes are conflict-prone.


https://reviews.llvm.org/D40182

Files:
  clangd/JSONExpr.cpp
  clangd/JSONExpr.h
  unittests/clangd/JSONExprTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40182.123363.patch
Type: text/x-patch
Size: 22732 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171117/798699b1/attachment-0001.bin>


More information about the cfe-commits mailing list