[PATCH] D40108: [clang-tidy] Adding Fuchsia checkers to clang-tidy

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 16 17:46:06 PST 2017


Eugene.Zelenko added a comment.

Does Fuchsia coding conventions allows default parameters in class methods? If not, test should reflect this



================
Comment at: docs/ReleaseNotes.rst:63
+
+  Prevent use of default arguments in declared or called functions in Fuchsia.
+
----------------
I think will be good idea to have description same as first sentence in documentation, i. e. //Warns if a function is declared or called with default arguments.//


================
Comment at: test/clang-tidy/fuchsia-default-arguments.cpp:6
+
+int f(void) {
+  foo();
----------------
Please remove //void// (see modernize-redundant-void-arg). Same below.


https://reviews.llvm.org/D40108





More information about the cfe-commits mailing list