[PATCH] D40141: [ObjC][ARC] Honor noescape attribute for -Warc-retain-cycles

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: lib/Sema/SemaChecking.cpp:11661
     if (Expr *capturer = findCapturingExpr(*this, msg->getArg(i), owner))
       return diagnoseRetainCycle(*this, capturer, owner);
+  }
----------------
Failing to find a capturing expression will overwhelmingly be the controlling condition here, so I would advise switching the order of the checks.

Otherwise, this patch looks good.


Repository:
  rL LLVM

https://reviews.llvm.org/D40141