[PATCH] D39918: [libunwind] Remove a FIXME about truncated section names
Martin Storsjö via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 16 11:36:59 PST 2017
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318446: Remove a FIXME about truncated section names (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39918?vs=122498&id=123223#toc
Repository:
rL LLVM
https://reviews.llvm.org/D39918
Files:
libunwind/trunk/src/AddressSpace.hpp
Index: libunwind/trunk/src/AddressSpace.hpp
===================================================================
--- libunwind/trunk/src/AddressSpace.hpp
+++ libunwind/trunk/src/AddressSpace.hpp
@@ -382,8 +382,6 @@
found_obj = true;
} else if (!strncmp((const char *)pish->Name, ".eh_frame",
IMAGE_SIZEOF_SHORT_NAME)) {
- // FIXME: This section name actually is truncated, ideally we
- // should locate and check the full long name instead.
info.dwarf_section = begin;
info.dwarf_section_length = pish->Misc.VirtualSize;
found_hdr = true;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39918.123223.patch
Type: text/x-patch
Size: 624 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20171116/9f2bca4b/attachment.bin>
More information about the cfe-commits
mailing list